Skip to content

Remove Bristlecone and Foxtail deprecated XmonDevices. #5483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2022

Conversation

MichaelBroughton
Copy link
Collaborator

Before removing XmonDevice outright, remove child classes.

@MichaelBroughton MichaelBroughton requested a review from dabacon June 10, 2022 19:25
@CirqBot CirqBot added the size: XL lines changed >1000 label Jun 10, 2022
@mpharrigan
Copy link
Collaborator

This raises some (imo) important JSON compatibility questions. #4321

As written, this PR drops support for a cirq_type completely and deletes the json test data (including the "inward" files). How hard would it be to include a shim to load the old data into a new GridDevice?

@mpharrigan
Copy link
Collaborator

mpharrigan commented Jun 13, 2022

although I see only the "old" files actually stored the qubit info; the others just give the device name. I don't know where/when that change was made. edit: changed very early on in #2527 with otherwise-unrelated changes, sadly

@mpharrigan
Copy link
Collaborator

Proposal: keep the json resolver but have it load into like the string name of the device or something; issue a warning telling users that these named devices no longer exist as of cirq version 0.16

or

port the named devices to GridDevice so that they still load in a devices with qubits and such and leave them be, as they are not hurting anyone and may be in some json documents.

@MichaelBroughton
Copy link
Collaborator Author

Went with your proposal. PTAL.

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- the json_inward files are left unchanged, so that's good

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 16, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 16, 2022
@CirqBot CirqBot merged commit 68fcde7 into quantumlib:master Jun 16, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 16, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Before removing XmonDevice outright, remove child classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: XL lines changed >1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants