-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove Bristlecone and Foxtail deprecated XmonDevices. #5483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This raises some (imo) important JSON compatibility questions. #4321 As written, this PR drops support for a |
although I see only the "old" files actually stored the qubit info; the others just give the device name. |
Proposal: keep the json resolver but have it load into like the string name of the device or something; issue a warning telling users that these named devices no longer exist as of cirq version 0.16 or port the named devices to GridDevice so that they still load in a devices with qubits and such and leave them be, as they are not hurting anyone and may be in some json documents. |
Went with your proposal. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- the json_inward
files are left unchanged, so that's good
Before removing XmonDevice outright, remove child classes.
Before removing XmonDevice outright, remove child classes.