cirq_google GridDevice: set JSON namespace to cirq.google #5512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
requested review from
wcourtney,
a team,
vtomole and
cduck
as code owners
95-martin-orion
approved these changes
Jun 14, 2022
| @@ -33,7 +33,6 @@ def _class_resolver_dictionary() -> Dict[str, ObjectFactory]: | |||
| 'GoogleNoiseProperties': cirq_google.GoogleNoiseProperties, | |||
| 'SycamoreGate': cirq_google.SycamoreGate, | |||
| 'GateTabulation': cirq_google.GateTabulation, | |||
| 'GridDevice': cirq_google.GridDevice, | |||
There was a problem hiding this comment.
[No change needed] As discussed, this is safe because GridDevice has not yet appeared in a Cirq release.
|
Yes, using the json "namespacing" feature is much preferred to coming up with new names that don't match the class name. All objects would ideally be namespaced (with a carveout for top-level |
verult
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
augustehirth
pushed a commit
to augustehirth/Cirq
that referenced
this pull request
Jun 15, 2022
…#5512) Preferred alternative over quantumlib#5476 (renaming `GridDevice` to `GoogleGridDevice`). This resolves the issue of JSON name collisions between cirq_google and elsewhere by including the `cirq.google` namespace. Furthermore, by staying with `GridDevice` as the class name, we require the caller to include the `cirq-google` module name in cases when multiple `GridDevice` classes are used (for example in the server side code today). @95-martin-orion @mpharrigan cc @dstrain115 @tanujkhattar
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…#5512) Preferred alternative over quantumlib#5476 (renaming `GridDevice` to `GoogleGridDevice`). This resolves the issue of JSON name collisions between cirq_google and elsewhere by including the `cirq.google` namespace. Furthermore, by staying with `GridDevice` as the class name, we require the caller to include the `cirq-google` module name in cases when multiple `GridDevice` classes are used (for example in the server side code today). @95-martin-orion @mpharrigan cc @dstrain115 @tanujkhattar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preferred alternative over #5476 (renaming
GridDevicetoGoogleGridDevice). This resolves the issue of JSON name collisions between cirq_google and elsewhere by including thecirq.googlenamespace.Furthermore, by staying with
GridDeviceas the class name, we require the caller to include thecirq-googlemodule name in cases when multipleGridDeviceclasses are used (for example in the server side code today).@95-martin-orion @mpharrigan
cc @dstrain115 @tanujkhattar