Add new function shell_tools.run #5528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A thin wrapper to subprocess.run with an extra options to log command arguments to stderr.
Default the `capture_output`, `check`, and `text` arguments to True to approximate behavior of run_cmd.
|
Premature PR - please hold with review... |
pavoljuhas
force-pushed
the
add-shell_tools.run
branch
from
3419bc4 to
9e9d9a5
Compare
dabacon
approved these changes
Jun 15, 2022
| **subprocess_run_kwargs, | ||
| ) -> subprocess.CompletedProcess: | ||
| """Call subprocess.run with an option to log executed command to stderr. | ||
|
|
There was a problem hiding this comment.
maybe something to distinguish why you would use this and not run_cmd below?
There was a problem hiding this comment.
Ack. I actually plan to remove run_cmd and run_shell in a followup PR and only use the run() function.
This PR is 1 of 4 for #4394.
Thanks for quick review.
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Add shell_tools.run, a thin wrapper to subprocess.run with a few extra arguments for showing the executed commands. It also supplies updated default values for subprocess.run to approximate behavior of run_cmd and run_shell functions. The purpose of this function is to replace the run_cmd and run_shell functions in the shell_tools module. Partially implements quantumlib#4394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shell_tools.run, a thin wrapper to subprocess.run with
a few extra arguments for showing the executed commands.
It also supplies updated default values for subprocess.run
to approximate behavior of run_cmd and run_shell functions.
The purpose of this function is to replace the run_cmd and
run_shell functions in the shell_tools module.
Partially implements #4394