Skip to content

Fix more flakes #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Fix more flakes #5537

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fba6f11
Fix more flakes
dabacon Jun 16, 2022
ed9925a
Merge branch 'master' into moreflake
dabacon Jun 16, 2022
ce67b30
Merge branch 'master' into moreflake
dabacon Jun 17, 2022
1cea48c
Merge branch 'master' into moreflake
CirqBot Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cirq-core/cirq/transformers/analytical_decompositions/two_qubit_to_cz_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,4 +265,4 @@ def test_decompose_to_diagonal_and_circuit(v):
assert cirq.is_diagonal(diagonal)
combined_circuit = cirq.Circuit(cirq.MatrixGate(diagonal)(b, c), ops)
circuit_unitary = combined_circuit.unitary(qubits_that_should_be_present=[b, c])
cirq.testing.assert_allclose_up_to_global_phase(circuit_unitary, v, atol=2e-6)
cirq.testing.assert_allclose_up_to_global_phase(circuit_unitary, v, atol=1e-5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[No change needed] I've seen relative difference in excess of 1e-5, but absolute is still below that mark.

Max absolute difference: 5.1897987e-06
Max relative difference: 1.1158966e-05

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I am giving it some room

Copy link
Collaborator

@95-martin-orion 95-martin-orion Jun 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just hit this again with worse error:

Max absolute difference: 4.5085162e-05
Max relative difference: 0.00063814

https://github.com/quantumlib/Cirq/runs/6926634541?check_suite_focus=true