Raise error instead of warning when downcasting from complex in apply_unitary
#5542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtomole
changed the title
cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and `ApplyUnitaryArgs.available_buffer inputs to np.complex128 cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and `=ApplyUnitaryArgs.available_buffer inputs to np.complex128
vtomole
changed the title
cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and `=ApplyUnitaryArgs.available_buffer inputs to np.complex128 cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and ApplyUnitaryArgs.available_buffer inputs to np.complex128
vtomole
force-pushed
the
cast_apply_unitary
branch
from
e883bfa to
18545c7
Compare
vtomole
changed the title
cirq.apply_unitary's ApplyUnitaryArgs.target_tensor and ApplyUnitaryArgs.available_buffer inputs to np.complex128 apply_unitary
vtomole
requested review from
pavoljuhas,
dabacon,
MichaelBroughton,
peterse,
alexandrupaler and
tanujkhattar
vtomole
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2041