Skip to content

Rename tetris_concat #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 23, 2022
Merged

Rename tetris_concat #5559

merged 8 commits into from
Jun 23, 2022

Conversation

daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Jun 19, 2022

Fixes #5556

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners June 19, 2022 01:18
@daxfohl daxfohl requested a review from pavoljuhas June 19, 2022 01:18
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 19, 2022
maffoo
maffoo approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@maffoo maffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think it's worth getting approval from another maintainer to have more eyes on the name.

@maffoo
Copy link
Contributor

maffoo commented Jun 21, 2022

Another thought, should we call this concat_ragged instead, since it's basically just a specific way to concatenate circuits, and concat is a name people will be familiar with.

@daxfohl
Copy link
Collaborator Author

daxfohl commented Jun 21, 2022

Added bikeshed session to cynq schedule tomorrow. (including, do we even want to do this at all)

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 23, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 23, 2022
@CirqBot CirqBot merged commit 13bb8dd into quantumlib:master Jun 23, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 23, 2022
@daxfohl daxfohl deleted the tetris branch June 24, 2022 05:29
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
Rename tetris_concat (quantumlib#5559)
786de4b 
Fixes quantumlib#5556
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@daxfohl
Rename tetris_concat (quantumlib#5559)
6ccf924 
Fixes quantumlib#5556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maffoo maffoo maffoo approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@pavoljuhas pavoljuhas Awaiting requested review from pavoljuhas pavoljuhas was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: L 250< lines changed <1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename tetris_concat?
4 participants
@daxfohl @maffoo @MichaelBroughton @CirqBot