Add cached_method decorator for per-instance method caches #5570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid repeated variable name `args`.
|
LGTM. Added a small tweak in 5f1d631 after getting thoroughly confused by the repeated args name. |
pavoljuhas
approved these changes
Jun 23, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…b#5570) Co-authored-by: Pavol Juhas <[email protected]>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…b#5570) Co-authored-by: Pavol Juhas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've found this to be quite useful internally for speeding things up, and I think it could help a lot in cirq, particularly in places where we have
_protocol_methods_that can't be written as properties, but that we don't want to recompute each time they are called on an instance.