Skip to content

Adds unitary testing for routed circuits #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 2, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cirq-core/cirq/testing/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

from cirq.testing.circuit_compare import (
assert_circuits_with_terminal_measurements_are_equivalent,
assert_circuits_have_same_unitary_given_final_permutation,
assert_has_consistent_apply_unitary,
assert_has_consistent_apply_unitary_for_various_exponents,
assert_has_diagram,
Expand Down
29 changes: 29 additions & 0 deletions cirq-core/cirq/testing/circuit_compare.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,35 @@ def _first_differing_moment_index(
return None # coverage: ignore


def assert_circuits_have_same_unitary_given_final_permutation(
actual: circuits.Circuit, expected: circuits.Circuit, qubit_map: Dict[ops.Qid, ops.Qid]
) -> None:
"""Asserts two circuits have the same unitary up to a final permuation of qubits.

Args:
actual: A circuit computed by some code under test.
expected: The circuit that should have been computed.
qubit_map: the permutation of qubits from the beginning to the end of the circuit.

Raises:
ValueError: if 'qubit_map' is not a mapping from the qubits in 'actual' to themselves.
"""
if any(not set(qs).issubset(actual.all_qubits()) for qs in zip(*tuple(qubit_map.items()))):
raise ValueError(
f"The dictionary 'qubit_map' must be a mapping of the qubits in the circuit 'actual'"
f" to themselves."
)

inverse_qubit_perm = {v: k for k, v in qubit_map.items()}
sorted_qubits, initial_qubits = zip(*sorted(inverse_qubit_perm.items(), key=lambda x: x[0]))
inverse_permutation = [sorted_qubits.index(q) for q in initial_qubits]
actual.append(ops.QubitPermutationGate(list(inverse_permutation)).on(*sorted_qubits))

lin_alg_utils.assert_allclose_up_to_global_phase(
expected.unitary(), actual.unitary(), atol=1e-8
)


def assert_has_diagram(
actual: Union[circuits.AbstractCircuit, circuits.Moment], desired: str, **kwargs
) -> None:
Expand Down
32 changes: 32 additions & 0 deletions cirq-core/cirq/testing/circuit_compare_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,38 @@ def test_assert_same_circuits():
)


def test_assert_circuits_have_same_unitary_given_final_permutation():
expected = cirq.Circuit(
[
cirq.Moment(
cirq.CNOT(cirq.NamedQubit('2'), cirq.NamedQubit('1')),
cirq.CNOT(cirq.NamedQubit('3'), cirq.NamedQubit('0')),
)
]
)
actual = cirq.Circuit(
[
cirq.Moment(cirq.CNOT(cirq.NamedQubit('2'), cirq.NamedQubit('1'))),
cirq.Moment(cirq.SWAP(cirq.NamedQubit('0'), cirq.NamedQubit('2'))),
cirq.Moment(cirq.SWAP(cirq.NamedQubit('0'), cirq.NamedQubit('1'))),
cirq.Moment(cirq.CNOT(cirq.NamedQubit('3'), cirq.NamedQubit('2'))),
]
)
qubit_map = {
cirq.NamedQubit('0'): cirq.NamedQubit('2'),
cirq.NamedQubit('1'): cirq.NamedQubit('0'),
cirq.NamedQubit('2'): cirq.NamedQubit('1'),
}
cirq.testing.assert_circuits_have_same_unitary_given_final_permutation(
actual, expected, qubit_map
)
qubit_map.update({cirq.NamedQubit('3'): cirq.NamedQubit('5')})
with pytest.raises(ValueError, match="The dictionary 'qubit_map' must"):
cirq.testing.assert_circuits_have_same_unitary_given_final_permutation(
actual, expected, qubit_map=qubit_map
)


def test_assert_has_diagram():
a, b = cirq.LineQubit.range(2)
circuit = cirq.Circuit(cirq.CNOT(a, b))
Expand Down