Skip to content

Print multi-qubit circuit with asymmetric depolarizing noise correctly #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 19, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cirq-core/cirq/ops/common_channels.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ def _circuit_diagram_info_(self, args: 'protocols.CircuitDiagramInfoArgs') -> st
]
else:
error_probabilities = [f"{pauli}:{p}" for pauli, p in self._error_probabilities.items()]
return f"A({', '.join(error_probabilities)})"
return [f"A({', '.join(error_probabilities)})"] + [
f'({i})' for i in range(1, self._num_qubits)
]

@property
def p_i(self) -> float:
Expand Down
8 changes: 4 additions & 4 deletions cirq-core/cirq/ops/common_channels_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -814,16 +814,16 @@ def test_multi_asymmetric_depolarizing_channel_str():
def test_multi_asymmetric_depolarizing_channel_text_diagram():
a = cirq.asymmetric_depolarize(error_probabilities={'II': 2 / 3, 'XX': 1 / 3})
assert cirq.circuit_diagram_info(a, args=no_precision) == cirq.CircuitDiagramInfo(
wire_symbols=('A(II:0.6666666666666666, XX:0.3333333333333333)',)
wire_symbols=('A(II:0.6666666666666666, XX:0.3333333333333333)', '(1)')
)
assert cirq.circuit_diagram_info(a, args=round_to_6_prec) == cirq.CircuitDiagramInfo(
wire_symbols=('A(II:0.666667, XX:0.333333)',)
wire_symbols=('A(II:0.666667, XX:0.333333)', '(1)')
)
assert cirq.circuit_diagram_info(a, args=round_to_2_prec) == cirq.CircuitDiagramInfo(
wire_symbols=('A(II:0.67, XX:0.33)',)
wire_symbols=('A(II:0.67, XX:0.33)', '(1)')
)
assert cirq.circuit_diagram_info(a, args=no_precision) == cirq.CircuitDiagramInfo(
wire_symbols=('A(II:0.6666666666666666, XX:0.3333333333333333)',)
wire_symbols=('A(II:0.6666666666666666, XX:0.3333333333333333)', '(1)')
)


Expand Down