Skip to content

CI - check consistency of requirements with pip-compile #5954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

pavoljuhas
Copy link
Collaborator

Make sure pip-compile can resolve direct and transient cirq dependencies.

Follow-up to #5929

@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners December 2, 2022 18:22
@pavoljuhas pavoljuhas requested a review from dstrain115 December 2, 2022 18:22
@CirqBot CirqBot added the size: S 10< lines changed <50 label Dec 2, 2022
@pavoljuhas
Copy link
Collaborator Author

@vtomole - can you PTAL when you get a chance?

run: pip install pip-tools
- name: Test dependencies with pip-compile
run: |
pip-compile --resolver=backtracking dev_tools/requirements/deps/cirq-all.txt -o-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the -o- for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -o- option writes the output to the standard output instead of a file.
It is nice to see the result in CI logs; also by default pip-compile may rewrite the requirements file, which I'd rather avoid.

Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Dec 8, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Dec 8, 2022
@CirqBot CirqBot merged commit b0de5cf into quantumlib:master Dec 8, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Dec 8, 2022
@pavoljuhas pavoljuhas deleted the add-ci-check-pip-compile branch December 8, 2022 21:10
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
)

Make sure pip-compile can resolve direct and transient cirq dependencies.

Follow-up to quantumlib#5929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants