Make sure the closefigures fixture is defined #5970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test_calibration_plot_histograms` references matplotlib.pyplot, but that module is not imported by default.
Problem: closefigures fixture is defined in the global conftest.py, which is not included in cirq packages. Package archives thus contain tests with undefined fixture. Solution: move closefigures definition to package conftest.py files.
pavoljuhas
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
viathor
approved these changes
Dec 20, 2022
tanujkhattar
approved these changes
Dec 20, 2022
pavoljuhas
added
the
automerge
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Add missing import of matplotlib.pyplot `test_calibration_plot_histograms` references matplotlib.pyplot, but that module is not imported by default. * Fix missing definition of the closefigures fixture Problem: closefigures fixture is defined in the global conftest.py, which is not included in cirq packages. Package archives thus contain tests with undefined fixture. Solution: move closefigures definition to package conftest.py files. * Fix function reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: closefigures fixture is defined in the global conftest.py,
which is not included in cirq packages. Package archives thus
contain tests with undefined fixture.
Solution: move closefigures definition to package conftest.py files.
Also add missing import of pyplot for
test_calibration_plot_histograms.