Optimize cached_method when wrapping no-arg methods #6381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the first time a no-arg cached method was called the decorator would make three calls: `hasattr`, `object.__setattr__`, `getattr`, and when called subsequently it would make two calls: `hasattr`, `getattr`. Here we refactor the implementation to use a sentinel value so that on the first call we only make two calls: `getattr`, `object.__setattr__`, and when called subsequently we only make a single `getattr` call.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6381 +/- ##
==========================================
- Coverage 97.81% 97.80% -0.01%
==========================================
Files 1111 1111
Lines 96948 96951 +3
==========================================
- Hits 94825 94824 -1
- Misses 2123 2127 +4 ☔ View full report in Codecov by Sentry. |
viathor
approved these changes
Dec 13, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Previously, the first time a no-arg cached method was called the decorator would make three calls: `hasattr`, `object.__setattr__`, `getattr`, and when called subsequently it would make two calls: `hasattr`, `getattr`. Here we refactor the implementation to use a sentinel value so that on the first call we only make two calls: `getattr`, `object.__setattr__`, and when called subsequently we only make a single `getattr` call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the first time a no-arg cached method was called the decorator would make three calls:
hasattr,object.__setattr__,getattr, and when called subsequently it would make two calls:hasattr,getattr. Here we refactor the implementation to use a sentinel value so that on the first call we only make two calls:getattr,object.__setattr__, and when called subsequently we only make a singlegetattrcall.