-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add warning when converting global phase operator to OpenQASM 2.0 #6476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NoureldinYosri
merged 10 commits into
quantumlib:main
from
kenya-sk:global_phase_warning
Feb 29, 2024
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9f63e68
add warning when converting global phase to QASM
kenya-sk 8e49e56
Merge remote-tracking branch 'upstream/main'
kenya-sk 03f0b79
Merge branch 'main' into global_phase_warning
NoureldinYosri 42a8d9d
fix code format
kenya-sk c7e2352
Merge branch 'main' into global_phase_warning
kenya-sk 86f5ead
Merge branch 'global_phase_warning' of github.com:kenya-sk/Cirq into …
kenya-sk 53258a8
change to test case suitable for issue
kenya-sk 95572ee
Merge branch 'main' into global_phase_warning
kenya-sk a2da0ee
handle multi global phase pattern
kenya-sk 4281e86
fix format
kenya-sk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the condition so that it works for the when the circuit has multiple global phases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overlooked that pattern. I've addressed it now.
Thank you for pointing it out!