-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove python3.9 from CI tests #6495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python3.9 from CI tests #6495
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6495 +/- ##
==========================================
- Coverage 97.76% 97.76% -0.01%
==========================================
Files 1105 1105
Lines 94999 95030 +31
==========================================
+ Hits 92873 92902 +29
- Misses 2126 2128 +2 ☔ View full report in Codecov by Sentry. |
Is everyone OK with removing the CI status checks for 3.9 (Python Ubuntu (3.9) etc.) in the repo settings now? |
@NoureldinYosri - there are few more places that I think can be bumped to 3.10 now, see below. Otherwise, LGTM.
|
@pavoljuhas I updated the requested files, ptal |
@pavoljuhas I changed the branch protection rule to be for 3.10 rather than 3.9 |
Did the same right now. Can you please push an empty commit to restart the CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one leftover at
Line 97 in 758ba16
Make sure you have python 3.9 or greater. |
Otherwise it is good to go.
first step towards dropping py3.9 in cirq1.4 #6463