Skip to content

Remove python3.9 from CI tests #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

NoureldinYosri
Copy link
Collaborator

@NoureldinYosri NoureldinYosri commented Mar 13, 2024

first step towards dropping py3.9 in cirq1.4 #6463

@NoureldinYosri NoureldinYosri requested review from vtomole, cduck and a team as code owners March 13, 2024 00:33
@NoureldinYosri NoureldinYosri requested a review from viathor March 13, 2024 00:33
@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 13, 2024
@NoureldinYosri NoureldinYosri changed the title Remove python3.9 from tests Remove python3.9 from CI tests Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (dc1065d) to head (758ba16).

❗ Current head 758ba16 differs from pull request most recent head 526e70f. Consider uploading reports for the commit 526e70f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6495      +/-   ##
==========================================
- Coverage   97.76%   97.76%   -0.01%     
==========================================
  Files        1105     1105              
  Lines       94999    95030      +31     
==========================================
+ Hits        92873    92902      +29     
- Misses       2126     2128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Copy link
Collaborator

Is everyone OK with removing the CI status checks for 3.9 (Python Ubuntu (3.9) etc.) in the repo settings now?
I can do so tomorrow unless there are objections.

@pavoljuhas
Copy link
Collaborator

@NoureldinYosri - there are few more places that I think can be bumped to 3.10 now, see below. Otherwise, LGTM.

.github/workflows/release-main.yml:18:          python-version: '3.9'
asv.conf.json:11:    "pythons": ["3.9"],
docs/dev/development.md:97:    Make sure you have python 3.9 or greater.
docs/start/install.md:15:Cirq currently supports python 3.9 and later.
docs/start/install.md:23:0. Make sure you have python 3.9.0 or greater.
docs/start/install.md:90:0. Make sure you have python 3.9.0 or greater.
docs/start/install.md:157:1. Make sure you have python 3.9.0 or greater.
release.md:85:System requirements: Linux, python3.9

@NoureldinYosri
Copy link
Collaborator Author

@pavoljuhas I updated the requested files, ptal

@NoureldinYosri
Copy link
Collaborator Author

@pavoljuhas I changed the branch protection rule to be for 3.10 rather than 3.9

@pavoljuhas
Copy link
Collaborator

@pavoljuhas I changed the branch protection rule to be for 3.10 rather than 3.9

Did the same right now. Can you please push an empty commit to restart the CI?

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one leftover at

Make sure you have python 3.9 or greater.

Otherwise it is good to go.

@NoureldinYosri NoureldinYosri enabled auto-merge (squash) March 14, 2024 19:48
@NoureldinYosri NoureldinYosri merged commit 2700f95 into quantumlib:main Mar 14, 2024
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants