-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Added random single-qubit CUE and Clifford gates #6670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added random single-qubit CUE and Clifford gates #6670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an initial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % a few nits
I'm OOO today so don't wait on my approval :)
Thanks Gaurav for improving this transformer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % passing coverage CI (just add one more test), and signing google contributor agreement.
Thanks for working on this!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6670 +/- ##
==========================================
- Coverage 97.82% 97.82% -0.01%
==========================================
Files 1072 1072
Lines 92030 92047 +17
==========================================
+ Hits 90028 90041 +13
- Misses 2002 2006 +4 ☔ View full report in Codecov by Sentry. |
* added cue and clifford gates * promoted rng check to the parent function * rename variables * minor fixes * minor formatting fix * added test coverage for ValueError * more formatting change --------- Co-authored-by: Seneca Meeks <[email protected]>
* added cue and clifford gates * promoted rng check to the parent function * rename variables * minor fixes * minor formatting fix * added test coverage for ValueError * more formatting change --------- Co-authored-by: Seneca Meeks <[email protected]>
Working from Seneca's last PR that provided
class RandomizedMeasurements
, I__call__
function to includeunitary_ensemble: str = "pauli"
which can be set to either"pauli"
,"clifford"
or"cue"
unitaries_to_moment
function withrandom_single_qubit_unitary_moment
to incorporate all three unitary ensembles instead of just Pauli