Exclude all setup.py files from typecheck #6690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py files specify distribution of cirq and cirq subpackages. There is no much value to enforce type annotations in their code. Fixes quantumlib#6687
The pattern was redundant as it did not match any file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6690 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1074 1074
Lines 92118 92118
=======================================
Hits 90116 90116
Misses 2002 2002 ☔ View full report in Codecov by Sentry. |
NoureldinYosri
approved these changes
Jul 31, 2024
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
setup.py files define distributions of cirq and cirq subpackages. There is no much value to enforce type annotations in their code. Also clean up ineffective exclusion pattern for cirq-rigetti (related to quantumlib#6661). Fixes quantumlib#6687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py files define distributions of cirq and cirq subpackages.
There is no much value to enforce type annotations in their code.
Also clean up ineffective exclusion pattern for cirq-rigetti (related to #6661).
Fixes #6687