Eliminate awful slowdown of EigenGate._value_equality_values_
#6695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The `sympy.Expr.is_constant()` introduced in quantumlib#6669 is very slow causing glacial-speed equality checks of parameterized gates. Solution: Check if expression is sympy.Number instead which still satisfies the equality fix added in quantumlib#6669. Timing of check/pytest --numprocesses=0 --randomly-seed=0 \ cirq-core/cirq/transformers/analytical_decompositions/two_qubit_to_sqrt_iswap_test.py Before: 945 s After: 18 s, Before quantumlib#6669: 18 s.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6695 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1074 1074
Lines 92126 92126
=======================================
Hits 90124 90124
Misses 2002 2002 ☔ View full report in Codecov by Sentry. |
viathor
approved these changes
Aug 1, 2024
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…tumlib#6695) Problem: The `sympy.Expr.is_constant()` introduced in quantumlib#6669 is very slow causing glacial-speed equality checks of parameterized gates. Solution: Check if expression is sympy.Number instead which still satisfies the equality fix added in quantumlib#6669. Timing of check/pytest --numprocesses=0 --randomly-seed=0 \ cirq-core/cirq/transformers/analytical_decompositions/two_qubit_to_sqrt_iswap_test.py Before: 945 s After: 18 s, Before quantumlib#6669: 18 s.
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…tumlib#6695) Problem: The `sympy.Expr.is_constant()` introduced in quantumlib#6669 is very slow causing glacial-speed equality checks of parameterized gates. Solution: Check if expression is sympy.Number instead which still satisfies the equality fix added in quantumlib#6669. Timing of check/pytest --numprocesses=0 --randomly-seed=0 \ cirq-core/cirq/transformers/analytical_decompositions/two_qubit_to_sqrt_iswap_test.py Before: 945 s After: 18 s, Before quantumlib#6669: 18 s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The
sympy.Expr.is_constant()introduced in #6669 is veryslow causing glacial-speed equality checks of parameterized gates.
Solution: Check if expression is sympy.Number instead which still
satisfies the equality fix added in #6669.
Timing of
check/pytest --numprocesses=0 --randomly-seed=0
cirq-core/cirq/transformers/analytical_decompositions/two_qubit_to_sqrt_iswap_test.py
Before: 945 s After: 18 s, Before #6669: 18 s.