Skip to content

Limit maximum multiprocessing pool size in xeb tests #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

pavoljuhas
Copy link
Collaborator

Problem: multiprocessing.Pool() uses all available cores which can
cause problems on hardware with many cores.

Solution: Limit the maximum pool size to 4.

Problem: `multiprocessing.Pool()` uses all available cores which can
cause problems on hardware with many cores.

Solution: Limit the maximum pool size to 4.
@pavoljuhas pavoljuhas requested review from mrwojtek, vtomole and a team as code owners August 29, 2024 18:39
@pavoljuhas pavoljuhas requested a review from mhucka August 29, 2024 18:39
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (6037f18) to head (2b98779).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6713      +/-   ##
==========================================
- Coverage   97.83%   97.83%   -0.01%     
==========================================
  Files        1077     1077              
  Lines       92482    92484       +2     
==========================================
+ Hits        90480    90481       +1     
- Misses       2002     2003       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas merged commit f0ead96 into quantumlib:main Aug 30, 2024
34 checks passed
@pavoljuhas pavoljuhas deleted the limit-mp-pool-size-in-tests branch August 31, 2024 00:07
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Problem: `multiprocessing.Pool()` uses all available cores which can
cause problems on hardware with many cores.

Solution: Limit the maximum pool size to 4.
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
Problem: `multiprocessing.Pool()` uses all available cores which can
cause problems on hardware with many cores.

Solution: Limit the maximum pool size to 4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants