Skip to content

Exclude conftest.py files from enforcing changed-code coverage #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

pavoljuhas
Copy link
Collaborator

Avoid spurious CI failure due to missing coverage of changed conftest.py lines.
conftest.py configures the pytest session. It is tricky and not worthwhile to
ensure it is test-covered.

Avoid spurious CI failure due to missing coverage of changed conftest.py lines.
conftest.py configures the pytest session.  It is tricky and not worthwhile to
ensure it is test-covered.
@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners September 20, 2024 00:19
@pavoljuhas pavoljuhas requested a review from mhucka September 20, 2024 00:31
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (484df6f) to head (325a88b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6738      +/-   ##
==========================================
- Coverage   97.83%   97.83%   -0.01%     
==========================================
  Files        1077     1077              
  Lines       92524    92524              
==========================================
- Hits        90523    90521       -2     
- Misses       2001     2003       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so that's the trick! Good to know.

@mhucka mhucka merged commit d15549c into quantumlib:main Sep 20, 2024
34 checks passed
@pavoljuhas pavoljuhas deleted the exclude-conftest-from-coverage branch September 20, 2024 17:10
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
…umlib#6738)

* Exclude conftest.py files from enforcing changed-code coverage

Avoid spurious CI failure due to missing coverage of changed conftest.py lines.
conftest.py configures the pytest session.  It is tricky and not worthwhile to
ensure it is test-covered.

* Typo - missing comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants