Use pytest fixture for multiprocessing Pool in XEB tests #6766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direct Pool executions causes flaky test outcomes in internal test framework. This change makes it easier to work around the problem. No change in the effective test code.
pavoljuhas
force-pushed
the
deflake-xeb-tests
branch
from
216eb61 to
9ed0fa5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6766 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 1077 1077
Lines 92672 92743 +71
=======================================
+ Hits 90669 90739 +70
- Misses 2003 2004 +1 ☔ View full report in Codecov by Sentry. |
mhucka
approved these changes
Oct 14, 2024
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…6766) Direct Pool executions cause flaky test outcomes in our internal test framework. This change makes it easier to work around the problem. No change in the effective test code.
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…6766) Direct Pool executions cause flaky test outcomes in our internal test framework. This change makes it easier to work around the problem. No change in the effective test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct Pool executions causes flaky test outcomes in internal test
framework. This change makes it easier to work around the problem.
No change in the effective test code.