Preliminary support for parsing OpenQASM 3.0 #6797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Nov 18, 2024
dstrain115
commented
- This adjusts the lexer and parser to handle programs from OpenQASM 3.0.
- This adjusts the lexer and parser to handle programs from OpenQASM 3.0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6797 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 1084 1084
Lines 93680 93715 +35
=======================================
+ Hits 91671 91706 +35
Misses 2009 2009 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pavoljuhas
reviewed
Nov 19, 2024
| @@ -315,13 +322,19 @@ def p_circuit_empty(self, p): | |||
|
|
|||
| def p_new_reg(self, p): | |||
| """new_reg : QREG ID '[' NATURAL_NUMBER ']' ';' | |||
| | CREG ID '[' NATURAL_NUMBER ']' ';'""" | |||
| name, length = p[2], p[4] | |||
| | QUBIT '[' NATURAL_NUMBER ']' ID ';' | |||
There was a problem hiding this comment.
The OpenQASM 3 seems to allow scalar qubits defined as qubit some_name;.
Would it be feasible to handle it here?
There was a problem hiding this comment.
Added scalar qubits (and bits)
pavoljuhas
approved these changes
Nov 19, 2024
pavoljuhas
reviewed
Nov 19, 2024
pavoljuhas
approved these changes
Nov 19, 2024
Co-authored-by: Pavol Juhas <[email protected]>
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Preliminary support for parsing OpenQASM 3.0 - This adjusts the lexer and parser to handle programs from OpenQASM 3.0. - This also adds the capability for scalar qubits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.