Skip to content

Add zip_longest in the cirq google sweep proto #6815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

BichengYing
Copy link
Collaborator

@BichengYing BichengYing commented Dec 3, 2024

Looks like the generated proto.py format is different. how can i I guarantee they are same? (I have checked the version of grpcio-tools and mypy-protobuf @pavoljuhas)

@BichengYing BichengYing requested review from wcourtney, vtomole, verult and a team as code owners December 3, 2024 22:14
@CirqBot CirqBot added the size: M 50< lines changed <250 label Dec 3, 2024
@pavoljuhas
Copy link
Collaborator

Looks like the generated proto.py format is different. how can i I guarantee they are same? (I have checked the version of grpcio-tools and mypy-protobuf @pavoljuhas)

I see the same error when running checks/protos-up-to-date for your PR.
What are the Python, grpcio-tools and mypy-protobuf versions on your side?

For me it is

Python 3.10.14
grpcio-tools   1.59.5
mypy-protobuf  3.6.0

If you have different versions, please run pip install -r dev_tools/requirements/deps/protos.txt in your virtual environment. Also make sure to use the dev_tools/build-protos.sh script to refresh the *_pb2.py files.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a tiny suggestion. Please re-generate the run_context_pb2.py file to unblock the CI.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (495d913) to head (bbeb10f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6815      +/-   ##
==========================================
- Coverage   97.85%   97.85%   -0.01%     
==========================================
  Files        1084     1084              
  Lines       93758    93764       +6     
==========================================
+ Hits        91749    91754       +5     
- Misses       2009     2010       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas merged commit e61e3be into quantumlib:main Dec 4, 2024
36 of 37 checks passed
@senecameeks senecameeks mentioned this pull request Dec 6, 2024
BichengYing added a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants