Skip to content

Disable streaming by default in cirq-google/cirq_google/engine/engine.py #6818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

senecameeks
Copy link
Collaborator

Now user's don't need to manually disable streaming. Will flip this once there's a fix.

@senecameeks senecameeks requested review from wcourtney, vtomole, verult and a team as code owners December 6, 2024 00:11
@CirqBot CirqBot added the Size: XS <10 lines changed label Dec 6, 2024
Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (e61e3be) to head (2aa2c37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6818   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files        1084     1084           
  Lines       93764    93764           
=======================================
  Hits        91755    91755           
  Misses       2009     2009           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@senecameeks senecameeks merged commit 35733fd into quantumlib:main Dec 6, 2024
37 checks passed
@mhucka mhucka changed the title disable streaming by default Disable streaming by default in cirq-google/cirq_google/engine/engine.py Apr 8, 2025
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants