-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add metadata into single sweep of cirq-google/cirq_google/api/v2/run_context.proto #6869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6869 +/- ##
==========================================
- Coverage 97.86% 97.86% -0.01%
==========================================
Files 1084 1084
Lines 94290 94290
==========================================
- Hits 92280 92279 -1
- Misses 2010 2011 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. My only concern is about testing the changes. Pardon my ignorance w.r.t. this part of the code, but is there any way to add test cases for this change?
About the test, it will be added after we have functional code calling this protobuf. (The python code generated here are auto-generated). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits
Continue #6869 This PR added a new path to encode and decode metadata to this corresponding proto. Notice this is a side path if the metadata in sweep is not encoded as `Metadata` class, the code path is still old and same for `from_proto` case. If the proto does not contain `metadata` proto field, the code still convert back as the old style
Continue quantumlib#6869 This PR added a new path to encode and decode metadata to this corresponding proto. Notice this is a side path if the metadata in sweep is not encoded as `Metadata` class, the code path is still old and same for `from_proto` case. If the proto does not contain `metadata` proto field, the code still convert back as the old style
The motivation of adding this metadata field (will replace
DeviceParameter
at least internal usage) is because of the headache during the development of cirq server.This is mainly to address the following three issues: