Skip to content

[cleanup] Remove unused GridParallelXEBMetadata class #6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ayshiff
Copy link
Contributor

@ayshiff ayshiff commented Jan 2, 2025

The GridParallelXEBMetadata class is not being used anywhere in the codebase.

Fixes #6601

The GridParallelXEBMetadata class is not being used anywhere in the codebase.
@ayshiff ayshiff requested review from mrwojtek, vtomole and a team as code owners January 2, 2025 06:06
@ayshiff ayshiff requested a review from fdmalone January 2, 2025 06:06
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jan 2, 2025
@dstrain115
Copy link
Collaborator

@pavoljuhas @mhucka This was moved to Recirq several years ago. Should this go through a deprecation cycle first?

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (686766f) to head (3e3f278).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6909      +/-   ##
==========================================
- Coverage   97.86%   97.86%   -0.01%     
==========================================
  Files        1084     1082       -2     
  Lines       94225    94261      +36     
==========================================
+ Hits        92215    92248      +33     
- Misses       2010     2013       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Copy link
Collaborator

This was moved to Recirq several years ago. Should this go through a deprecation cycle first?

The code that used GridParallelXEBMetadata was removed in #5674 which preceded the 1.0.0 release.
If some users still use it, they either already have to install an old cirq or they use it from ReCirq.

I am OK with merging as is, but anyone please shout if you see some serious drawback.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking care of this!

@dstrain115 dstrain115 added this pull request to the merge queue Jan 19, 2025
Merged via the queue into quantumlib:main with commit 55c592b Jan 19, 2025
37 checks passed
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
)

The `GridParallelXEBMetadata` class is not being used anywhere in the
codebase.

Fixes quantumlib#6601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cleanup] Delete GridParallelXEBMetadata
4 participants