-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix the format of CliffordGate repr. #7046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7046 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 1089 1089
Lines 95201 95208 +7
=======================================
+ Hits 93471 93478 +7
Misses 1730 1730 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit test should compare with a constant expected string. Otherwise LGTM.
Updated the code, I will hold this PR for reivew, if it looks good, I will submit tomorrow afternoon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for fixing this!
* fix the format of CliffordGate repr. * Add unit tests for CliffordGate.__repr__() * Check the full string of repr without calling _str_full_. * remove test cases * Strip trailing blanks in the expected repr(gate) string --------- Co-authored-by: Pavol Juhas <[email protected]>
Remove one space to align output CliffordTableau correctly.
Before:
After: