Skip to content

Fix the format of CliffordGate repr. #7046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Conversation

babacry
Copy link
Collaborator

@babacry babacry commented Feb 8, 2025

Remove one space to align output CliffordTableau correctly.

Before:

Clifford Gate with Tableau:
 stable | destable
-------+----------
- Z0   | + Y0

After:

Clifford Gate with Tableau:
stable | destable
-------+----------
- Z0   | + Y0

@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 8, 2025
@babacry babacry marked this pull request as ready for review February 8, 2025 04:15
@babacry babacry requested review from vtomole and a team as code owners February 8, 2025 04:15
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (bc9fc97) to head (2200995).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7046   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files        1089     1089           
  Lines       95201    95208    +7     
=======================================
+ Hits        93471    93478    +7     
  Misses       1730     1730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 11, 2025
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test should compare with a constant expected string. Otherwise LGTM.

@babacry
Copy link
Collaborator Author

babacry commented Feb 12, 2025

Updated the code, I will hold this PR for reivew, if it looks good, I will submit tomorrow afternoon.

@babacry babacry requested a review from pavoljuhas February 12, 2025 02:31
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this!

@pavoljuhas pavoljuhas enabled auto-merge February 12, 2025 19:15
@pavoljuhas pavoljuhas added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@pavoljuhas pavoljuhas enabled auto-merge February 12, 2025 20:04
@pavoljuhas pavoljuhas added this pull request to the merge queue Feb 12, 2025
Merged via the queue into quantumlib:main with commit dd3df78 Feb 12, 2025
38 checks passed
@babacry babacry deleted the clif_repr branch February 21, 2025 06:14
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
* fix the format of CliffordGate repr.

* Add unit tests for CliffordGate.__repr__()

* Check the full string of repr without calling _str_full_.

* remove test cases

* Strip trailing blanks in the expected repr(gate) string

---------

Co-authored-by: Pavol Juhas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50 Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants