Skip to content

Remove apt package pandoc and add shellcheck #7096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Feb 25, 2025

pandoc is not used since #3587, but we do use shellcheck.

Also sort package names.

pandoc is not used since quantumlib#3587, but we however use shellcheck.

Also sort package names.
@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners February 25, 2025 20:13
@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (7a834a0) to head (f5350fb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7096   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files        1089     1089           
  Lines       95177    95177           
=======================================
+ Hits        93438    93439    +1     
+ Misses       1739     1738    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas requested a review from mhucka February 26, 2025 01:04
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue Feb 26, 2025
Merged via the queue into quantumlib:main with commit d8ec3e4 Feb 26, 2025
38 checks passed
@pavoljuhas pavoljuhas deleted the freshen-apt-dev-tools-list branch February 26, 2025 03:11
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
pandoc is not used since quantumlib#3587, but we however use shellcheck.

Also sort package names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants