Skip to content

Make small fixes to linalg.decompositions #7128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

babacry
Copy link
Collaborator

@babacry babacry commented Mar 7, 2025

  • Remove unused code.
  • Actual raise in kron 4x4 to 2x2s (raise was in docstring, but not actualized). Update related tests as well.
  • Other nit fixes.

@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (78d30e7) to head (45db532).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7128   +/-   ##
=======================================
  Coverage   98.16%   98.17%           
=======================================
  Files        1093     1093           
  Lines       95420    95441   +21     
=======================================
+ Hits        93665    93695   +30     
+ Misses       1755     1746    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babacry babacry changed the title Small fixes of linalg.decomposition Small fixes of linalg.decompositions Mar 8, 2025
@babacry babacry marked this pull request as ready for review March 8, 2025 01:41
@babacry babacry requested review from vtomole and a team as code owners March 8, 2025 01:41
@babacry babacry requested a review from dabacon March 8, 2025 01:41
@babacry
Copy link
Collaborator Author

babacry commented Mar 12, 2025

I created this PR while reading the beautiful su2xsu2->so4 homomorphism implementaion.

Just cosmetic changes to improve the healthiness of the codebase. @NoureldinYosri @pavoljuhas @dstrain115 , wonder how can I properly add reviewers for this =) given that the auto assigned reviewers might be out of date?

@babacry babacry added kind/health For CI/testing/release process/refactoring/technical debt items area/linalg area/decomposition labels Mar 12, 2025
Copy link
Collaborator

@NoureldinYosri NoureldinYosri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @babacry , thanks for catching this

@NoureldinYosri NoureldinYosri added this pull request to the merge queue Mar 12, 2025
Merged via the queue into quantumlib:main with commit e014f4d Mar 12, 2025
38 checks passed
@mhucka mhucka changed the title Small fixes of linalg.decompositions Make small fixes to linalg.decompositions Apr 8, 2025
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
* Small fixes of linalg.decomposition.

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/decomposition area/linalg kind/health For CI/testing/release process/refactoring/technical debt items size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants