Skip to content

Fix WaitGate for multiple qubits in cirq_google proto #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix WaitGate for multiple qubits in cirq_google proto #7189

merged 1 commit into from
Mar 26, 2025

Conversation

dstrain115
Copy link
Collaborator

  • WaitGate operations with multiple qubits need to specify the num_qubits parameter.
  • This PR fixes this and adds an appropriate test case.

@dstrain115
Fix WaitGate for multiple qubits in cirq_google proto
494c273 
- WaitGate operations with multiple qubits need to specify
the `num_qubits` parameter.
- This PR fixes this and adds an appropriate test case.
@dstrain115 dstrain115 requested review from wcourtney, vtomole, verult and a team as code owners March 26, 2025 15:21
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (0eea89e) to head (494c273).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7189      +/-   ##
==========================================
- Coverage   98.14%   98.14%   -0.01%     
==========================================
  Files        1100     1100              
  Lines       96191    96191              
==========================================
- Hits        94409    94408       -1     
- Misses       1782     1783       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dstrain115 dstrain115 requested a review from senecameeks March 26, 2025 15:59
@dstrain115 dstrain115 added this pull request to the merge queue Mar 26, 2025
Merged via the queue into quantumlib:main with commit c95af3e Mar 26, 2025
39 checks passed
@dstrain115 dstrain115 deleted the fix_wait_gate branch March 26, 2025 18:13
@mhucka mhucka mentioned this pull request Apr 18, 2025
Merged
This was referenced May 30, 2025
Merged
Open
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
@dstrain115 @BichengYing
Fix WaitGate for multiple qubits in cirq_google proto (quantumlib#7189)
d7295aa 
- WaitGate operations with multiple qubits need to specify
the `num_qubits` parameter.
- This PR fixes this and adds an appropriate test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney wcourtney is a code owner

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@verult verult Awaiting requested review from verult verult is a code owner

@senecameeks senecameeks Awaiting requested review from senecameeks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstrain115 @pavoljuhas