Fix isort invocation in format-incremental #7194
Conversation
These files are already formatted by black.
Skip isort execution altogether if only `__init__.py` files changed.
|
Verified |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7194 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 1100 1100
Lines 96191 96191
==========================================
- Hits 94407 94404 -3
- Misses 1784 1787 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cool, thanks! I was wondering offline if it might be better to loop through all the files and call both isort and black on each of them one by one. That'd let us print out an aggregate metric at the end, as to how many files would be affected. But super low priority and there may be disadvantages to that approach too.
Anyway, this lgtm
* format-incremental - include files in cirq-google/cirq_google/cloud These files are already formatted by black. * format-incremental - exclude `__init__.py` files from isort targets Skip isort execution altogether if only `__init__.py` files changed.
Exclude
__init__.pyfiles from isort targets.Skip isort execution altogether if only
__init__.pyfiles changed.Make files in
cirq-google/cirq_google/cloudsubject to formatting.They were already formatted by black.
Follow up to #7190, #7181
Fixes #4863