Skip to content

Improve check of expected shell commands in check/format-incremental #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

pavoljuhas
Copy link
Collaborator

Set the CI environment variable to get the --color option unconditionally.
Also check if isort is invoked.

Follow-up to #7181

Set the `CI` environment variable to get the `--color` option unconditionally.
Also check if `isort` is invoked.

Follow-up to quantumlib#7181
@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners March 27, 2025 19:54
@pavoljuhas pavoljuhas requested a review from fdmalone March 27, 2025 19:54
@pavoljuhas
Copy link
Collaborator Author

This fixes the pytest failure due to a missing --color option when run locally -

$ pytest dev_tools/bash_scripts_test.py

FAILED dev_tools/bash_scripts_test.py::test_incremental_format_branch_selection - assert 'INTERCEPTED black --color --check --diff alt.py' in 'Sorting imports with isort... (version: 6.0....

@pavoljuhas pavoljuhas requested a review from mhucka March 27, 2025 20:00
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (0f652e1) to head (5c68ac4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7196      +/-   ##
==========================================
- Coverage   98.14%   98.14%   -0.01%     
==========================================
  Files        1100     1100              
  Lines       96191    96192       +1     
==========================================
- Hits        94409    94408       -1     
- Misses       1782     1784       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhucka mhucka added this pull request to the merge queue Mar 27, 2025
Merged via the queue into quantumlib:main with commit fa18b82 Mar 27, 2025
39 checks passed
@pavoljuhas pavoljuhas deleted the fix-script-test branch March 27, 2025 21:06
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
…uantumlib#7196)

Set the `CI` environment variable to get the `--color` option unconditionally.
Also check if `isort` is invoked.

Follow-up to quantumlib#7181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants