Flip back to default use_repetition_ids=True in CircuitOperation
#7237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uantumlib#6910)" Put back the default `use_repetition_ids=True` so we do not make API change without deprecation warning. This reverts commit 5ffb3ad.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7237 +/- ##
==========================================
- Coverage 98.65% 98.64% -0.02%
==========================================
Files 1106 1106
Lines 95992 95990 -2
==========================================
- Hits 94704 94690 -14
- Misses 1288 1300 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dstrain115
approved these changes
Apr 8, 2025
pavoljuhas
deleted the
flip-back-and-warn-about-use_repetition_ids-change
branch
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Apr 9, 2025
…n_ids default to False Revert "Flip back to default `use_repetition_ids=True` in CircuitOperation (quantumlib#7237)" This reverts commit 58d9619. This also finalizes quantumlib#7232
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Apr 11, 2025
…n_ids default to False Revert "Flip back to default `use_repetition_ids=True` in CircuitOperation (quantumlib#7237)" This reverts commit 58d9619. This also finalizes quantumlib#7232
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…uantumlib#7237) * Revert "CircuitOperation: change use_repetition_ids default to False (quantumlib#6910)" Put back the default `use_repetition_ids=True` so we do not make API change without deprecation warning. This reverts commit 5ffb3ad. * Add FutureWarning for upcoming change of use_repetition_ids default * Adjust unit tests for default `use_repetition_ids=True`
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…n_ids default to False (quantumlib#7265) Revert "Flip back to default `use_repetition_ids=True` in CircuitOperation (quantumlib#7237)" This reverts commit 58d9619. This also finalizes quantumlib#7232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "CircuitOperation: change
use_repetition_idsdefault to False (CircuitOperation: change use_repetition_ids default to False #6910)"Put back the default
use_repetition_ids=Trueso we do not makeAPI change without a warning notification in minor release.
Add FutureWarning for upcoming change of
use_repetition_idsdefault.Adjust unit tests to work with default
use_repetition_ids=TruePartially resolves #7232