Avoid using NotImplemented as a boolean #7259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address DeprecationWarning: NotImplemented should not be used in a boolean context This fixes check/pytest -Werror:"NotImplemented should":DeprecationWarning
maffoo
approved these changes
Apr 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7259 +/- ##
==========================================
- Coverage 98.64% 98.64% -0.01%
==========================================
Files 1106 1106
Lines 95985 95985
==========================================
- Hits 94688 94686 -2
- Misses 1297 1299 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
babacry
pushed a commit
to babacry/Cirq
that referenced
this pull request
Apr 9, 2025
Address DeprecationWarning: NotImplemented should not be used in a boolean context This fixes check/pytest -Werror:"NotImplemented should":DeprecationWarning
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
Address DeprecationWarning: NotImplemented should not be used in a boolean context This fixes check/pytest -Werror:"NotImplemented should":DeprecationWarning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address
DeprecationWarning: NotImplemented should not be used in a boolean contextThis fixes