Skip to content

Fix serialization error in cirq_google. #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Fix serialization error in cirq_google. #7260

merged 2 commits into from
Apr 9, 2025

Conversation

dstrain115
Copy link
Collaborator

  • If empty, invert_mask is converted to an empty tuple object.
  • This is not yet supported server-side.

@dstrain115
Fix serialization error in cirq_google.
f2ecf73 
- If empty, invert_mask is converted to an empty tuple object.
- This is not yet supported server-side.
@dstrain115 dstrain115 requested review from wcourtney, vtomole, verult and a team as code owners April 9, 2025 21:51
@dstrain115 dstrain115 enabled auto-merge April 9, 2025 21:56
@dstrain115 dstrain115 added this pull request to the merge queue Apr 9, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (66c630b) to head (cc30043).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7260   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files        1106     1106           
  Lines       95990    95986    -4     
=======================================
- Hits        94691    94689    -2     
+ Misses       1299     1297    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into quantumlib:main with commit da6ec5d Apr 9, 2025
38 checks passed
@dstrain115 dstrain115 deleted the fix_measurement_empty_tuple branch April 9, 2025 22:25
@mhucka mhucka mentioned this pull request Apr 18, 2025
Merged
This was referenced May 30, 2025
Merged
Open
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
@dstrain115 @BichengYing
Fix serialization error in cirq_google. (quantumlib#7260)
3bf8735 
* Fix serialization error in cirq_google.

- If empty, invert_mask is converted to an empty tuple object.
- This is not yet supported server-side.

* Fix typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcourtney wcourtney wcourtney approved these changes

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@verult verult Awaiting requested review from verult verult is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstrain115 @wcourtney @NoureldinYosri