Ignore false positives from osv-scanner #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSV prior to version 2.0 is unable to parse pip version specs correctly, as explained by one of the developers in the following comment from January 2025: google/osv-scanner#1483 (comment) The suggested workaround is to configure osv-scanner to ignore the particular cases it complains about. The following are all about NumPy, because osv-scanner can't understand the version spec "numpy>=1.24,<2.0" and therefore raises errors about all versions of NumPy, including very old ones. Ignoring these specific dependencies is okay because we will never use the old versions of NumPy and it doesn't block detection of future new vulnerabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSV prior to version 2.0 is unable to parse pip version specs correctly, as explained by one of the developers in the following comment from January 2025:
google/osv-scanner#1483 (comment)
The suggested workaround is to configure osv-scanner to ignore the particular cases it complains about. The following are all about NumPy, because osv-scanner can't understand the version spec "numpy>=1.24,<2.0" and therefore raises errors about all versions of NumPy, including very old ones. Ignoring these specific dependencies is okay because we will never use the old versions of NumPy and it doesn't block detection of future new vulnerabilities.