Fix warning about asyncio.get_event_loop() in Python 3.12 #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.12, the code in `shell_tools.py` produces the following warnings when running `check/pytest`: ``` dev_tools/shell_tools_test.py::test_run_cmd_raise_on_fail dev_tools/shell_tools.py:185: DeprecationWarning: There is no current event loop result = asyncio.get_event_loop().run_until_complete( ``` The fix involves managing the event loop. The updated functions now try to get the current running event loop; if no loop is running, they create a new one, use it, and then close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.12, the code in
shell_tools.pyproduces the following warnings when runningcheck/pytest:The fix involves managing the event loop. The updated functions now try to get the current running event loop; if no loop is running, they create a new one, use it, and then close it.
Note: commit c3ab0fa has the actual code changes. Commit ba775f5 contains purely formatting changes from applying
check/format-incremental.