Remove doc source files from installation #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #887. Including the documentation `.md` and tutorial `.ipynb` files in the `pip` package installation seems unnecessary; the file end up in a very unusual location (which users are unlikely to find) and the docs/tutorials are online (https://quantumai.google/openfermion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #887. It removes the documentation source files from the installation.
Including the documentation
.mdand tutorial.ipynbfiles in thepippackage installation seems unnecessary; the file end up in a very unusual location where users are unlikely to find them (which makes the value of their inclusion questionable), and the same content is available online (https://quantumai.google/openfermion).