Add AutoPartition and BloqBuilder.add_and_partition to fit bloqs together whose registers don't quite match
#1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI @fdmalone |
Collaborator
|
One of the motivations in the linked PR was to clean up the circuit diagrams by hiding the partition/unpartition pairs behind a level of decomposition. Does this still do that? |
Collaborator
|
Awesome, I was thinking the AutoPartition would be a bloq by itself (like Split and Join) and then the bloq builder would use this bloq (similar to split and join), but this works too. |
charlesyuan314
changed the title
BloqBuilder.add_and_partition to fit bloqs together whose registers don't quite matchAutoPartition and BloqBuilder.add_and_partition to fit bloqs together whose registers don't quite match
Contributor
Author
|
I made |
mpharrigan
reviewed
Jun 21, 2024
mpharrigan
reviewed
Jun 21, 2024
mpharrigan
reviewed
Jun 21, 2024
mpharrigan
reviewed
Jun 21, 2024
mpharrigan
reviewed
Jun 21, 2024
mpharrigan
reviewed
Jun 21, 2024
mpharrigan
reviewed
Jun 24, 2024
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
Very comprehensive! Thanks for adding docs as well. LGTM modulo wording fixes on the flag-for-one-sidedness
Contributor
Author
|
@mpharrigan PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the implementation of the wrapper bloq introduced in #789 and adds an alternative interface to it as a
BloqBuilderutility method.