Add Unitary and TensorProduct block encodings
#1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesyuan314
commented
Jul 1, 2024
tanujkhattar
requested changes
Jul 1, 2024
Collaborator
tanujkhattar
left a comment
tanujkhattar
left a comment
There was a problem hiding this comment.
Great start, left a round of comments.
tanujkhattar
reviewed
Jul 1, 2024
charlesyuan314
force-pushed
the
be
branch
2 times, most recently
from
762f61b to
0facb74
Compare
tanujkhattar
reviewed
Jul 2, 2024
tanujkhattar
reviewed
Jul 2, 2024
tanujkhattar
approved these changes
Jul 2, 2024
Collaborator
tanujkhattar
left a comment
tanujkhattar
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the changes!
Please open issues to track
- Migration of NotImplementedError to abc.abstractmethods.
- Implementation of signal_state for the newly added block encodings.
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instances of
BlockEncodingthat implement 1) a trivial block encoding of a unitary operator and 2) a tensor product of block encodings.Extend the
BlockEncodinginterface to expose the propertiesalpha,ancilla_bitsize, andepsilonof block encodings.With the newly designed block encoding interface, the
selection_registers,junk_registers, andtarget_registersmethods should now be considered deprecated and will be removed in a future PR.