[QECGatesCost] Adjustments part 3 #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurudhp
approved these changes
Aug 22, 2024
Contributor
anurudhp
left a comment
anurudhp
left a comment
There was a problem hiding this comment.
lgtm % doubt regarding Controlled override
| ZPowGate, | ||
| ) | ||
|
|
||
| if isinstance(b, Controlled): |
Contributor
There was a problem hiding this comment.
This branch captures any CtrlSpec right? For non-trivial ctrl-spec, shouldn't we error out? (or use the and-ladder, but perhaps for later) #1290
Collaborator
Author
There was a problem hiding this comment.
yes, that is an issue; but not a new issue introduced by this PR. Let me see if I can sneak a quick fix in or if it'll be a whole thing; in which case, I will defer to another PR
Collaborator
Author
There was a problem hiding this comment.
I could -- there aren't any places in the unit tests or bloq examples that relies on Controlled(rot, #cvs>1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic is slightly inconsistent within itself, but it matches the previous behavior from the
t_complexityprotocol. We count Controlled(Rotation) as a rotation no matter what the rotation angle is. The ultimate fix is blocked by having explicit representations for all leaf controlled locations (#878).