Remove pretty_name part 1 #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
approved these changes
Aug 24, 2024
| if len(point_str) < 5 or True: | ||
| return f'PE${point_str}$' | ||
| return 'PE(R)' | ||
| def __str__(self) -> str: |
Contributor
There was a problem hiding this comment.
Any concerns about dropping the long string condition?
Collaborator
Author
There was a problem hiding this comment.
if you look closely, this seems to actually have been some debug code that snuck through (mea culpa) because of the or True condition.
Collaborator
Author
|
Test failure is due to different precision of string representations of floating point values locally vs ci. I can choose an arbitrary precision, but then the format string fails for sympy objects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default implementation of
Bloq.pretty_nameto go via__str__. Start removingpretty_nameimplementations and moving them to__str__orwire_symbolsas necessary.towards #791