First preparations for making And an atomic/leaf bloq #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdmalone
approved these changes
Aug 26, 2024
Collaborator
|
That test failure is a bit confusing... is it secretly a float or something, the amount printed is 276 |
due to change away from defaultdict
Collaborator
Author
|
The proximate cause was changing the return value of classify bloqs from defaultdict to a dictionary. The "other" key didn't actually exist -- everything is categorized now. Idk if we should customize the categorization scheme to combine the toffolis and multi_control whatever into an "other" category so they match. I took the liberty of changing the notebook code to print the union of keys in the paper costs, binned costs (and default to zero) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial steps towards #1346
I can only do so many of these changes in an afternoon, so all the changes in this PR make tests work for either
Andas leaf or non-leaf; and I put the leafiness behind a flag.