Change build_call_graph in bloqs to return dict #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This changes the build_call_graph function within bloqs in qualtran to return a dictionary of cost counts rather than a set. - This will allow the ordering of cost counts to be deterministic Note that this requires some slight code changes for bloqs that have multiple set items since (Toffoli(), 1) and (Toffoli(), 2) would have two different items in a set, but share an index in the dictionary. This also may alter counts (i.e. fix a bug) where set items clobber each other. For instance, adding (Toffoli(), self.bits_a) and (Toffoli(), self.bits_b) will previously give the wrong count if bits_a == bits_b since the two items would be the same in the set.
mpharrigan
reviewed
Sep 6, 2024
Comment on lines
84
to
93
| cost[SignedIntegerToTwosComplement(self.num_bits_p)] += 3 | ||
| cost[SignedIntegerToTwosComplement(self.num_bits_n)] += 3 | ||
| # Adding nu into p / q. Nu is one bit larger than p. | ||
| cost_add_p = (Add(QInt(self.num_bits_p + 1)), 3) | ||
| cost_add_n = (Add(QInt(self.num_bits_n + 1)), 3) | ||
| cost_ctrl_add_p = (Toffoli(), 3 * (self.num_bits_p + 1)) | ||
| cost_ctrl_add_n = (Toffoli(), 3 * (self.num_bits_n + 1)) | ||
| cost[Add(QInt(self.num_bits_p + 1))] += 3 | ||
| cost[Add(QInt(self.num_bits_n + 1))] += 3 | ||
| cost[Toffoli()] += 3 * (self.num_bits_p + 1) | ||
| cost[Toffoli()] += 3 * (self.num_bits_n + 1) | ||
| # + 2 as these numbers are larger from addition of $\nu$ | ||
| cost_inv_tc_p = (SignedIntegerToTwosComplement(self.num_bits_p + 2), 3) | ||
| cost_inv_tc_n = (SignedIntegerToTwosComplement(self.num_bits_n + 2), 3) | ||
| cost[SignedIntegerToTwosComplement(self.num_bits_p + 2)] += 3 | ||
| cost[SignedIntegerToTwosComplement(self.num_bits_n + 2)] += 3 |
Collaborator
There was a problem hiding this comment.
i feel like there may be some information lost by removing those variable names? Not blocking, but maybe include in comments, eg the cost[Toffoli()] += 3 * self.num_bits_p is for ctrl_add_p which isn't otherwise obvious
mpharrigan
reviewed
Sep 6, 2024
| # of $T$ thus we come to our total. | ||
| # Eq 73. page | ||
| return {(Toffoli(), (5 * (self.num_bits_p - 1) + 2))} | ||
| # Eq 73, page 20. |
Collaborator
|
didn't mean to conflict you. I'll try to fix them up quick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this requires some slight code changes for bloqs that have multiple set items since (Toffoli(), 1) and (Toffoli(), 2) would have two different items in a set, but share an index in the dictionary.
This also may alter counts (i.e. fix a bug) where set items clobber each other. For instance, adding (Toffoli(), self.bits_a) and (Toffoli(), self.bits_b) will previously give the wrong count if bits_a == bits_b since the two items would be the same in the set.