Remove pretty_name part 3 #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default implementation of Bloq.pretty_name to go via str. Removing pretty_name implementations and moving them to str or wire_symbols as necessary. This change removes all references to pretty_name
fdmalone
approved these changes
Sep 10, 2024
Collaborator
|
nice. can you fix the two notebooks as well? |
mpharrigan
requested changes
Sep 10, 2024
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
Hold off on merging until I cut v0.5
Contributor
Author
|
Ok, notebooks fixed. Feel free to merge when ready |
anurudhp
reviewed
Sep 11, 2024
qualtran/_infra/adjoint.py
Outdated
Comment on lines
170
to
172
|
|
||
| def pretty_name(self) -> str: | ||
| """The subbloq's pretty_name with a dagger.""" | ||
| return self.subbloq.pretty_name() + '†' | ||
|
|
||
| def __str__(self) -> str: | ||
| """Delegate to subbloq's `__str__` method.""" | ||
| return f'Adjoint(subbloq={str(self.subbloq)})' |
Contributor
There was a problem hiding this comment.
could we use str(subbloq) + dagger in __str__ instead of Adjoint(subloq=...)? It would make the diagrams easier to read.
Collaborator
There was a problem hiding this comment.
+1, I wanted to do this for a while; but feared the test changes that would need to accompany it
anurudhp
approved these changes
Sep 11, 2024
mpharrigan
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default implementation of Bloq.pretty_name to go via str. Removing pretty_name implementations and moving them to str or wire_symbols as necessary.
This change removes all references to pretty_name