Add RSA Phase Estimate Bloq and Move ModExp to rsa/ subdirectory #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think we discussed offline, but +1 to the top-level bloq. This should be set up as "phase estimation of the modular multiply operation". -1 to the signature change of ModExp, but maybe we don't include modexp as part of the decomposition if we frame the overall algorithm as phase estimation of modmul |
…able modular exponentiation circuit
fpapa250
changed the title
mpharrigan
reviewed
Oct 15, 2024
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
some nits, but looking good!
mpharrigan
reviewed
Oct 17, 2024
mpharrigan
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a higher level top bloq with the phase estimation for shors for RSA. I also moved the bloqs to an rsa/ directory and moved the MeasureQFT shim to the factoring/ directory. Last, I made the ModExp bloq take an (n_exponent,) shaped QBit() register because the controls are used in the plus state in the phase estimation circuit so it can't be of type QUint (I think).