Simplify QubitizationWalkOperator: remove specializations for control/adjoint and use defaults instead
#1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
anurudhp
force-pushed
the
2024/10/29-refactor-walk-op
branch
from
ed3f295 to
5ea723a
Compare
… and controlled versions do not match
anurudhp
force-pushed
the
2024/10/29-refactor-walk-op
branch
from
e7f4b2e to
1df30f6
Compare
Contributor
Author
mpharrigan
reviewed
Oct 30, 2024
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
initial review, thanks for the ping
anurudhp
force-pushed
the
2024/10/29-refactor-walk-op
branch
from
c8afa13 to
e1dabca
Compare
mpharrigan
reviewed
Nov 1, 2024
mpharrigan
reviewed
Nov 1, 2024
anurudhp
force-pushed
the
2024/10/29-refactor-walk-op
branch
from
5579ff0 to
b1165b3
Compare
mpharrigan
reviewed
Nov 4, 2024
qualtran/bloqs/chemistry/hubbard_model/qubitization/select_hubbard.py
Outdated
Show resolved
Hide resolved
mpharrigan
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #1266
QubitizationWalkOperatordoes not need a specialized control, it is handled automatically by the select and reflect ops it decomposes to. The bloq/cirq diagrams also match the default inControlled.TwoBitSwap,ZGate,YGate.AdjointWithSpecializedCtrlmetabloq, which pushes single bit controls to the subbloq. This fixesAdjointprevents specialized control bloqs from being constructed #1480SelectHubbard. Also fix a bug in it: the decomp does not account forcontrol_val=0, so use default for that case.