Replace ModInv shim with KaliskiModInverse in ECAdd bloq #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#1443 - this issue is fixed now because we use KaliskiModInverse for classical simulation instead of my hacky temp solution. |
NoureldinYosri
approved these changes
Nov 5, 2024
mpharrigan
reviewed
Nov 5, 2024
| # toffoli cost for Kaliski Mod Inverse, n extra toffolis in ModNeg, 2n extra toffolis to do n | ||
| # 3-controlled toffolis in step 2. The expression is written with rationals because sympy | ||
| # comparison fails with floats. | ||
| assert total_toff == sympy.Rational(253, 2) * n**2 + sympy.Rational(391, 2) * n - 31 |
Collaborator
There was a problem hiding this comment.
something that might help here or in the future: when comparing sympy expressions, the equality operator tests for the same literal expression. If you want to test for mathematical equality x = y you can test simplify(x-y)==0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ModInv shim as it is no longer used
Replaces it with KaliskiModInverse bloq in ECAdd
Improves the gate count test to match toffoli count expected with bloq swap