Fix bug in KaliskiStep3 and add tests for all steps #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
can you add a PR description |
Contributor
Author
added |
22 tasks
This was referenced Jan 29, 2025
This was referenced Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was bug in the decomposition of KaliskiStep3 where a variable
junkwas assigned twice and freed twice.there were also a few minor things in classical action of other bloqs. the reason these were not caught before is that the tests are written for the top level KaliskiModInverse which decomposes into _KaliskiIteration ... so the classically action of the _KaliskiIteration was tested, but the decomposition of _KaliskiIteration into steps wasn't. so I added tests to check all decomposition down the decomposition of each step