Initial benchmarks #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
reviewed
Nov 22, 2023
| Execute(ctx, "octane/zlib-data.js", JS_EVAL_TYPE_GLOBAL); | ||
| Execute(ctx, "octane/typescript.js", JS_EVAL_TYPE_GLOBAL); | ||
| Execute(ctx, "octane/typescript-input.js", JS_EVAL_TYPE_GLOBAL); | ||
| Execute(ctx, "octane/typescript-compiler.js", JS_EVAL_TYPE_GLOBAL); |
There was a problem hiding this comment.
It would maybe run these in their own contexts because then there's no risk of one benchmark clobbering another (because they all pollute the global scope like mad.)
On the other hand, V8 didn't do that either so 🤷
There was a problem hiding this comment.
Each benchmark registers itself to the BenchmarkSuite global so it needs to be in the same context.
saghul
reviewed
Nov 23, 2023
saghul
reviewed
Nov 25, 2023
saghul
approved these changes
Nov 29, 2023
|
little bump, anything else left for this PR? |
bnoordhuis
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.