-
Notifications
You must be signed in to change notification settings - Fork 174
Support for non-CL Clang on Windows #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
c7a9a92
2b1f713
51f5332
1607d47
bb6dfe0
6731454
3073f11
deb2196
f08401e
de85fe6
0ccbeae
9529a1b
e311961
833f67a
ebee0ce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -208,10 +208,11 @@ static void js_set_thread_state(JSRuntime *rt, JSThreadState *ts) | |
js_std_cmd(/*SetOpaque*/1, rt, ts); | ||
} | ||
|
||
#ifdef __GNUC__ | ||
// Non-CL Clang on Windows does not define __GNUC__ | ||
#if defined(__GNUC__) || defined(__clang__) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't clang-on-windows define
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe it does too. What are you trying to fix here @HJfod ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
#pragma GCC diagnostic push | ||
#pragma GCC diagnostic ignored "-Wformat-nonliteral" | ||
#endif // __GNUC__ | ||
#endif // __GNUC__ || __clang__ | ||
static JSValue js_printf_internal(JSContext *ctx, | ||
int argc, JSValueConst *argv, FILE *fp) | ||
{ | ||
|
@@ -427,9 +428,9 @@ static JSValue js_printf_internal(JSContext *ctx, | |
dbuf_free(&dbuf); | ||
return JS_EXCEPTION; | ||
} | ||
#ifdef __GNUC__ | ||
#if defined(__GNUC__) || defined(__clang__) | ||
#pragma GCC diagnostic pop // ignored "-Wformat-nonliteral" | ||
#endif // __GNUC__ | ||
#endif // __GNUC__ || __clang__ | ||
|
||
uint8_t *js_load_file(JSContext *ctx, size_t *pbuf_len, const char *filename) | ||
{ | ||
|
Uh oh!
There was an error while loading. Please reload this page.